Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@WebFluxTest does not enable auto-configuration for any reactive template engines #16170

Closed
wants to merge 3 commits into from
Closed

@WebFluxTest does not enable auto-configuration for any reactive template engines #16170

wants to merge 3 commits into from

Conversation

ayudovin
Copy link
Contributor

@ayudovin ayudovin commented Mar 8, 2019

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 8, 2019
@wilkinsona
Copy link
Member

wilkinsona commented Mar 8, 2019 •
edited

Thanks for the PR. Unfortunately, this isn't the change that we need. Rather than creating separate annotations, the auto-configurations for the template engines with reactive support need to be included in @WebFluxTest. That can be achieved by adding them to the existing org.springframework.boot.test.autoconfigure.web.reactive.AutoConfigureWebFlux entry in spring.factories. Would you like to update your PR to do that?

@ayudovin
Copy link
Contributor Author

ayudovin commented Mar 8, 2019

@wilkinsona, yes, I would like to update my PR.

wilkinsona
wilkinsona approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@wilkinsona wilkinsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me know. Thank you, @ayudovin.

@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 8, 2019
@wilkinsona wilkinsona added this to the 2.1.x milestone Mar 8, 2019
@wilkinsona wilkinsona mentioned this pull request Mar 8, 2019
Closed
@snicoll snicoll self-assigned this Mar 12, 2019
@snicoll snicoll modified the milestones: 2.1.x, 2.1.4 Mar 12, 2019
snicoll pushed a commit that referenced this pull request Mar 12, 2019
@ayudovin @snicoll
Add support for Mustache, FreeMarker and Thymeleaf in WebFluxTest
5101342 
See gh-16170
snicoll added a commit that referenced this pull request Mar 12, 2019
@snicoll
Merge pull request #16170 from ayudovin
015de55 
* pr/16170:
  Polish contribution
  Add support for Mustache, FreeMarker and Thymeleaf in WebFluxTest
@snicoll snicoll closed this in 161c0b9 Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snicoll snicoll snicoll approved these changes

@wilkinsona wilkinsona wilkinsona approved these changes

Assignees

@snicoll snicoll

Labels
type: bug A general bug
Projects
None yet
Milestone
2.1.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ayudovin @wilkinsona @snicoll @spring-projects-issues