Random management.server.port should not set to the same value as local.server.port #16108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
nosan
changed the title
management.server.port should be 0 
mbhave
added
type: bug
mbhave
reviewed
Mar 8, 2019
| @@ -57,7 +57,7 @@ public void postProcessEnvironment(ConfigurableEnvironment environment, | |||
| } | |||
| Integer serverPort = getPropertyAsInteger(environment, SERVER_PORT_PROPERTY, | |||
| 8080); | |||
| if (!managementPort.equals(serverPort)) { | |||
| if (!managementPort.equals(serverPort) || managementPort == 0) { | |||
the same value and `management.server.port` has been defined in the different PropertySource spring-projectsgh-16102
mbhave
added a commit
that referenced
this pull request
Mar 16, 2019
* pr/16108: Test server port shouldn't affect management port when random
|
Thanks @nosan. This is now on 2.1.x and master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
management.server.portshould be 0 whenlocal.server.porthas the same value andmanagement.server.porthas been defined in the differentPropertySourcegh-16102