Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When MongoReactiveAutoConfiguration creates a MongoClient that uses Netty, EventLoopGroup threads prevent the JVM from exiting #16087

Closed
wants to merge 1 commit into from
Closed

When MongoReactiveAutoConfiguration creates a MongoClient that uses Netty, EventLoopGroup threads prevent the JVM from exiting #16087

wants to merge 1 commit into from

Conversation

nosan
Copy link
Contributor

@nosan nosan commented Mar 4, 2019

@nosan
The default event loop group is not shutdown properly.
e1c27b9 
This commit sets a custom event loop group with a destroy method which
will be called during application closing.

spring-projectsgh-15675
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 4, 2019
@nosan nosan changed the title The default event loop group is not shutdown properly. The default event loop group is not being shutdown properly. Mar 4, 2019
@wilkinsona wilkinsona changed the title The default event loop group is not being shutdown properly. Application with spring.main.web-application-type=NONE doesn't shut down in conjunction with data mongodb reactive starter Apr 2, 2019
@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 2, 2019
@wilkinsona wilkinsona added this to the 2.1.x milestone Apr 2, 2019
@wilkinsona wilkinsona mentioned this pull request Apr 2, 2019
Closed
@wilkinsona wilkinsona self-assigned this Apr 2, 2019
@wilkinsona wilkinsona changed the title Application with spring.main.web-application-type=NONE doesn't shut down in conjunction with data mongodb reactive starter When MongoReactiveAutoConfiguration creates a MongoClient that uses Netty EventLoopGroup threads prevent the JVM from exiting Apr 2, 2019
@wilkinsona wilkinsona changed the title When MongoReactiveAutoConfiguration creates a MongoClient that uses Netty EventLoopGroup threads prevent the JVM from exiting When MongoReactiveAutoConfiguration creates a MongoClient that uses Netty, EventLoopGroup threads prevent the JVM from exiting Apr 2, 2019
@wilkinsona wilkinsona modified the milestones: 2.1.x, 2.1.4 Apr 2, 2019
wilkinsona pushed a commit that referenced this pull request Apr 2, 2019
@nosan @wilkinsona
Ensure that MongoClient's EventLoopGroup is shut down during context …
ee7bed1 
…close

See gh-16087
wilkinsona added a commit that referenced this pull request Apr 2, 2019
@wilkinsona
Polish "Ensure that MongoClient's EventLoopGroup is shut down during …
f20d9a6 
…context close"

See gh-16087
@wilkinsona wilkinsona closed this in fe4c83a Apr 2, 2019
@wilkinsona
Copy link
Member

Thanks very much for the PR, @nosan. The proposed changes have been merged into 2.1.x and forward into master along with a little bit of polish.

@nosan nosan deleted the gh-15675 branch April 2, 2019 11:18
@nosan
Copy link
Contributor Author

nosan commented Apr 2, 2019

@wilkinsona Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wilkinsona wilkinsona

Labels
type: bug A general bug
Projects
None yet
Milestone
2.1.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nosan @wilkinsona @spring-projects-issues