Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug mode is not logging web and sql related loggers #16018

Closed
wants to merge 1 commit into from
Closed

Debug mode is not logging web and sql related loggers #16018

wants to merge 1 commit into from

Conversation

nosan
Copy link
Contributor

@nosan nosan commented Feb 22, 2019

see gh-15986

Thanks!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 22, 2019
@nosan nosan force-pushed the gh-15986 branch 3 times, most recently from 8c95649 to a001e28 Compare February 22, 2019 12:35
@nosan nosan changed the title web and sql groups are being expanded to the logger names that each represents web and sql groups must be expanded to the logger names that each represents Feb 22, 2019
@wilkinsona wilkinsona mentioned this pull request Feb 26, 2019
Closed
@wilkinsona wilkinsona added this to the 2.1.x milestone Feb 26, 2019
@wilkinsona wilkinsona added type: regression A regression from a previous release and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 26, 2019
@snicoll snicoll self-assigned this Feb 27, 2019
@snicoll snicoll changed the title web and sql groups must be expanded to the logger names that each represents Debug mode is not logging web and sql related loggers Feb 27, 2019
snicoll pushed a commit that referenced this pull request Feb 27, 2019
@nosan @snicoll
Debug mode is not logging web and sql related loggers
c3430d5 
See gh-16018
snicoll added a commit that referenced this pull request Feb 27, 2019
@snicoll
Merge pull request #16018 from nosan
2236e95 
* pr/16018:
  Polish "Debug mode is not logging web and sql related loggers"
  Debug mode is not logging web and sql related loggers
@snicoll snicoll modified the milestones: 2.1.x, 2.1.4 Feb 27, 2019
@snicoll snicoll closed this in 978f801 Feb 27, 2019
@snicoll
Copy link
Member

snicoll commented Feb 27, 2019

Thank you again @nosan. I've merged your contribution to 2.1.x and master with a polish commit as I didn't like the use of Optional.

@nosan nosan deleted the gh-15986 branch February 27, 2019 12:54
@nosan
Copy link
Contributor Author

nosan commented Feb 27, 2019

@snicoll Thanks, you are right. Optional is not necessary here at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: regression A regression from a previous release
Projects
None yet
Milestone
2.1.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nosan @snicoll @wilkinsona @spring-projects-issues