Use InvalidEndpointRequestException for MetricsEndpoint.metric() #14291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
reviewed
Sep 3, 2018
| @@ -80,8 +80,12 @@ private String getName(Meter meter) { | |||
| @ReadOperation | |||
| public MetricResponse metric(@Selector String requiredMetricName, | |||
| @Nullable List<String> tag) { | |||
| Assert.isTrue(tag == null || tag.stream().allMatch((t) -> t.contains(":")), | |||
| "Each tag parameter must be in the form key:value"); | |||
| if (tag != null && tag.stream().anyMatch((t) -> !t.contains(":"))) { | |||
There was a problem hiding this comment.
Perhaps we should move that to the parseTag method and add a test for it? the existing code that checks there is : in the String is a bit weak as well.
There was a problem hiding this comment.
@snicoll Thanks for the quick feedback! I updated as you suggested.
izeye
force-pushed
the
metrics-endpoint-metric
branch
from
e85bd44
to
c45e4c3
Compare
snicoll
approved these changes
Sep 4, 2018
snicoll
added
type: bug
|
Looks good @izeye, thanks again! |
snicoll
added a commit
that referenced
this pull request
Sep 4, 2018
* pr/14291: Use InvalidEndpointRequestException for MetricsEndpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes to use
InvalidEndpointRequestExceptionforMetricsEndpoint.metric()instead ofAssertas theAssertwill end up with responding with 500 for invalid requests, not 400.