Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated configuration properties #20991

Closed
dreis2211 opened this issue Apr 16, 2020 · 3 comments
Closed

Remove deprecated configuration properties #20991

dreis2211 opened this issue Apr 16, 2020 · 3 comments
Assignees
@snicoll
Labels
type: enhancement A general enhancement
Milestone
2.3.0.RC1

Comments

@dreis2211
Copy link
Contributor

dreis2211 commented Apr 16, 2020 •
edited

Hi,

I just noticed that the deprecated server.connection-timeout was deprecated in 2.1.x already (see #18473) . While relatively late in the 2.3.x release, I was wondering if we could remove it still for 2.3.x?

If the decision is made to remove it, I'm happy to do it in a PR. Let me know what you think.

Cheers,
Christoph
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 16, 2020
@snicoll
Copy link
Member

snicoll commented Apr 17, 2020 •
edited

Thanks for the nudge @dreis2211. I've noticed additional properties that should have been cleaned up from the 2.2.x release:

  • server.use-forward-headers
  • server.tomcat.max-http-post-size
  • server.jetty.max-http-post-size

Removing connect-timeout seems a no brainer to me but I do wonder about those three so late in the 2.3.x release indeed. Flagging for team attention to see what the rest of the team think.

@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label Apr 17, 2020
@dreis2211
Copy link
Contributor Author

dreis2211 commented Apr 17, 2020 •
edited

I think they were missed because they didn't have a @deprecated since 2.1.x. Anyhow, if you made up your mind I'm happy to provide a PR for it.

@snicoll snicoll mentioned this issue Apr 17, 2020
Closed
@snicoll
Copy link
Member

snicoll commented Apr 17, 2020

Those 3 were deprecated in 2.2.x but I think you're right. I've added a comment to that effect in #20812

@philwebb philwebb added type: task A general task and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Apr 17, 2020
@philwebb philwebb added this to the 2.3.x milestone Apr 17, 2020
@snicoll snicoll self-assigned this Apr 19, 2020
@snicoll snicoll changed the title Remove deprecated server.connection-timeout property Remove deprecated configuration properties Apr 19, 2020
@snicoll snicoll modified the milestones: 2.3.x, 2.3.0.RC1 Apr 19, 2020
@dreis2211 dreis2211 mentioned this issue May 1, 2020
Closed
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed type: task A general task labels May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.3.0.RC1
Development

No branches or pull requests
5 participants
@snicoll @philwebb @wilkinsona @dreis2211 @spring-projects-issues