New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate getters and setters for deprecated configuration properties consistently #20812
Comments
hi, would like to be a new contributor, can I take this for starters? |
@shahaf-sameach Thanks for the offer. Yes, please give that a try and let us know how it goes. |
I think going forward we should also make sure to add @shahaf-sameach how is it going by the way? Do you need any help? |
We could add a |
hi @snicoll, thank you, just wanted to ask if that is straight forward as it seems, look for any |
Yes. |
@shahaf-sameach and I discussed offline and we've decided I would take over this one after all. |
When we deprecate a configuration property, we add
@DeprecatedConfigurationProperty
to thegetter
along with a@Deprecated
on the getter and setter. We don't do this consistently though. This is one example where the getter and setter don't have@Deprecated
.The text was updated successfully, but these errors were encountered: