Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate PushRegistryConfig#numThreads #20835

Closed
snicoll opened this issue Apr 4, 2020 · 1 comment
Closed

Deprecate PushRegistryConfig#numThreads #20835

snicoll opened this issue Apr 4, 2020 · 1 comment
Assignees
@snicoll
Labels
type: enhancement A general enhancement
Milestone
2.2.7

Comments

@snicoll
Copy link
Member

snicoll commented Apr 4, 2020

The PushRegistryConfig#numThreads javadoc states:

  • @deprecated since 1.1.13 because this configuration is not used

We're using Micrometer 1.3 so that deprecation is quite overdue. We can deprecate it in 2.2.x and remove it in 2.3 still.
@snicoll snicoll added the type: task A general task label Apr 4, 2020
@snicoll snicoll added this to the 2.2.x milestone Apr 4, 2020
@snicoll snicoll added type: enhancement A general enhancement and removed type: task A general task labels Apr 5, 2020
@snicoll snicoll changed the title Deprecated PushRegistryConfig#numThreads Deprecate PushRegistryConfig#numThreads Apr 5, 2020
@snicoll snicoll mentioned this issue Apr 5, 2020
Closed
@snicoll
Copy link
Member Author

snicoll commented Apr 5, 2020

The version of micrometer we have does not flag the property has deprecated yet as it's quite recent, see micrometer-metrics/micrometer#1900

@snicoll snicoll self-assigned this Apr 5, 2020
@snicoll snicoll modified the milestones: 2.2.x, 2.2.7 Apr 5, 2020
@snicoll snicoll mentioned this issue Apr 5, 2020
Closed
@snicoll snicoll closed this as completed in 1960c90 Apr 5, 2020
snicoll added a commit that referenced this issue Apr 5, 2020
@snicoll
Remove PushRegistry's numThreads deprecated property
7ca6359 
See gh-20835
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.2.7
Development

No branches or pull requests
1 participant
@snicoll