Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AtlasProperties hierarchy #20843

Closed
snicoll opened this issue Apr 5, 2020 · 0 comments
Closed

Fix AtlasProperties hierarchy #20843

snicoll opened this issue Apr 5, 2020 · 0 comments
Assignees
@snicoll
Labels
type: task A general task
Milestone
2.2.7

Comments

@snicoll
Copy link
Member

snicoll commented Apr 5, 2020

AtlasProperties currently extends from StepRegistryProperties (that's a PushRegistryProperties). Yet, its config counterpart in micrometer does not.

We should harmonize the hierarchies in the context of #20835 as numThreads is not deprecated for Atlas.
@snicoll snicoll added the type: task A general task label Apr 5, 2020
@snicoll snicoll added this to the 2.2.x milestone Apr 5, 2020
@snicoll snicoll self-assigned this Apr 5, 2020
@snicoll snicoll modified the milestones: 2.2.x, 2.2.7 Apr 5, 2020
@snicoll snicoll mentioned this issue Apr 5, 2020
Closed
@snicoll snicoll closed this as completed in 4641794 Apr 5, 2020
@luispollo luispollo mentioned this issue Oct 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: task A general task
Projects
None yet
Milestone
2.2.7
Development

No branches or pull requests
1 participant
@snicoll