-
Notifications
You must be signed in to change notification settings - Fork 40.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make Logback fall back to JVM's default charset
The charset "default" is an alias for US-ASCII, not the JVM's default charset. This commit updates the built-in Logback configuration to use Charset.defaultCharset().name() in place of "default" in the Java-based configuration. In the XML-based configuration where Charset.defaultCharset().name() cannot be called, we emulate its behaviour [1] by using the file.encoding system property, falling back to UTF-8 when it's not set. Fixes gh-27230 [1] https://github.com/openjdk/jdk8u/blob/19be6113dd0f658f950583b751284961d8ce0458/jdk/src/share/classes/java/nio/charset/Charset.java#L604-L617
- Loading branch information
1 parent
22d85e6
commit e4e1958
Showing
2 changed files
with
8 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters