Fix validation when key matching the prefix is set

Fixes gh-15597
spring-projects · Jan 10, 2019 · b345fc8 · b345fc8
1 parent ce62a96
commit b345fc8
Show file tree

Hide file tree

Showing 2 changed files with 57 additions and 3 deletions.
diff --git a/...va/org/springframework/boot/context/properties/bind/validation/ValidationBindHandler.java b/...va/org/springframework/boot/context/properties/bind/validation/ValidationBindHandler.java
@@ -76,6 +76,17 @@ public void onFinish(ConfigurationPropertyName name, Bindable<?> target,
 		super.onFinish(name, target, context, result);
 	}
 
+	@Override
+	public Object onFailure(ConfigurationPropertyName name, Bindable<?> target,
+			BindContext context, Exception error) throws Exception {
+		Object result = super.onFailure(name, target, context, error);
+		validate(name, target, context, null);
+		if (!this.exceptions.isEmpty()) {
+			throw this.exceptions.pop();
+		}
+		return result;
+	}
+
 	private void validate(ConfigurationPropertyName name, Bindable<?> target,
 			BindContext context, Object result) {
 		Object validationTarget = getValidationTarget(target, context, result);

diff --git a/...g/springframework/boot/context/properties/bind/validation/ValidationBindHandlerTests.java b/...g/springframework/boot/context/properties/bind/validation/ValidationBindHandlerTests.java
@@ -27,6 +27,8 @@
 import org.junit.Before;
 import org.junit.Test;
 
+import org.springframework.boot.context.properties.bind.AbstractBindHandler;
+import org.springframework.boot.context.properties.bind.BindContext;
 import org.springframework.boot.context.properties.bind.BindException;
 import org.springframework.boot.context.properties.bind.Bindable;
 import org.springframework.boot.context.properties.bind.Binder;
@@ -35,6 +37,7 @@
 import org.springframework.boot.context.properties.source.ConfigurationPropertySource;
 import org.springframework.boot.context.properties.source.MockConfigurationPropertySource;
 import org.springframework.boot.origin.Origin;
+import org.springframework.core.convert.ConverterNotFoundException;
 import org.springframework.validation.FieldError;
 import org.springframework.validation.ObjectError;
 import org.springframework.validation.annotation.Validated;
@@ -57,12 +60,14 @@ public class ValidationBindHandlerTests {
 
 	private Binder binder;
 
+	private LocalValidatorFactoryBean validator;
+
 	@Before
 	public void setup() {
 		this.binder = new Binder(this.sources);
-		LocalValidatorFactoryBean validator = new LocalValidatorFactoryBean();
-		validator.afterPropertiesSet();
-		this.handler = new ValidationBindHandler(validator);
+		this.validator = new LocalValidatorFactoryBean();
+		this.validator.afterPropertiesSet();
+		this.handler = new ValidationBindHandler(this.validator);
 	}
 
 	@Test
@@ -162,6 +167,34 @@ public void bindShouldNotValidateDepthGreaterThanZero() {
 				this.handler);
 	}
 
+	@Test
+	public void bindShouldNotValidateIfOtherHandlersInChainThrowError() {
+		this.sources.add(new MockConfigurationPropertySource("foo", "hello"));
+		ExampleValidatedBean bean = new ExampleValidatedBean();
+		assertThatExceptionOfType(BindException.class)
+				.isThrownBy(
+						() -> this.binder.bind("foo",
+								Bindable.of(ExampleValidatedBean.class)
+										.withExistingValue(bean),
+								this.handler))
+				.withCauseInstanceOf(ConverterNotFoundException.class);
+	}
+
+	@Test
+	public void bindShouldValidateIfOtherHandlersInChainIgnoreError() {
+		TestHandler testHandler = new TestHandler();
+		this.handler = new ValidationBindHandler(testHandler, this.validator);
+		this.sources.add(new MockConfigurationPropertySource("foo", "hello"));
+		ExampleValidatedBean bean = new ExampleValidatedBean();
+		assertThatExceptionOfType(BindException.class)
+				.isThrownBy(
+						() -> this.binder.bind("foo",
+								Bindable.of(ExampleValidatedBean.class)
+										.withExistingValue(bean),
+								this.handler))
+				.withCauseInstanceOf(BindValidationException.class);
+	}
+
 	private BindValidationException bindAndExpectValidationError(Runnable action) {
 		try {
 			action.run();
@@ -265,4 +298,14 @@ public int getAge() {
 
 	}
 
+	static class TestHandler extends AbstractBindHandler {
+
+		@Override
+		public Object onFailure(ConfigurationPropertyName name, Bindable<?> target,
+				BindContext context, Exception error) throws Exception {
+			return null;
+		}
+
+	}
+
 }