Merge pull request #19000 from thelproad

* pr/19000: Remove redundant code Closes gh-19000
spring-projects · Nov 23, 2019 · 36f4d2f · 36f4d2f
2 parents 0c5bb60 + 65ab82b
commit 36f4d2f
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8 deletions.
diff --git a/...rk/boot/actuate/autoconfigure/web/servlet/ServletManagementChildContextConfiguration.java b/...rk/boot/actuate/autoconfigure/web/servlet/ServletManagementChildContextConfiguration.java
@@ -190,7 +190,7 @@ public void customize(JettyServletWebServerFactory factory) {
 
 		private void customizeServer(Server server) {
 			RequestLog requestLog = server.getRequestLog();
-			if (requestLog != null && requestLog instanceof CustomRequestLog) {
+			if (requestLog instanceof CustomRequestLog) {
 				customizeRequestLog((CustomRequestLog) requestLog);
 			}
 		}

diff --git a/...uator/src/main/java/org/springframework/boot/actuate/endpoint/web/EndpointMediaTypes.java b/...uator/src/main/java/org/springframework/boot/actuate/endpoint/web/EndpointMediaTypes.java
@@ -51,7 +51,7 @@ public class EndpointMediaTypes {
 	 * @since 2.2.0
 	 */
 	public EndpointMediaTypes(String... producedAndConsumed) {
-		this((producedAndConsumed != null) ? Arrays.asList(producedAndConsumed) : (List<String>) null);
+		this((producedAndConsumed != null) ? Arrays.asList(producedAndConsumed) : null);
 	}
 
 	/**

diff --git a/...src/main/java/org/springframework/boot/autoconfigure/AutoConfigurationImportSelector.java b/...src/main/java/org/springframework/boot/autoconfigure/AutoConfigurationImportSelector.java
@@ -279,7 +279,7 @@ protected final <T> List<T> removeDuplicates(List<T> list) {
 
 	protected final List<String> asList(AnnotationAttributes attributes, String name) {
 		String[] value = attributes.getStringArray(name);
-		return Arrays.asList((value != null) ? value : new String[0]);
+		return Arrays.asList(value);
 	}
 
 	private void fireAutoConfigurationImportEvents(List<String> configurations, Set<String> exclusions) {

diff --git a/...e/src/main/java/org/springframework/boot/autoconfigure/condition/OnResourceCondition.java b/...e/src/main/java/org/springframework/boot/autoconfigure/condition/OnResourceCondition.java
@@ -24,7 +24,6 @@
 import org.springframework.context.annotation.ConditionContext;
 import org.springframework.core.Ordered;
 import org.springframework.core.annotation.Order;
-import org.springframework.core.io.DefaultResourceLoader;
 import org.springframework.core.io.ResourceLoader;
 import org.springframework.core.type.AnnotatedTypeMetadata;
 import org.springframework.util.Assert;
@@ -39,14 +38,11 @@
 @Order(Ordered.HIGHEST_PRECEDENCE + 20)
 class OnResourceCondition extends SpringBootCondition {
 
-	private final ResourceLoader defaultResourceLoader = new DefaultResourceLoader();
-
 	@Override
 	public ConditionOutcome getMatchOutcome(ConditionContext context, AnnotatedTypeMetadata metadata) {
 		MultiValueMap<String, Object> attributes = metadata
 				.getAllAnnotationAttributes(ConditionalOnResource.class.getName(), true);
-		ResourceLoader loader = (context.getResourceLoader() != null) ? context.getResourceLoader()
-				: this.defaultResourceLoader;
+		ResourceLoader loader = context.getResourceLoader();
 		List<String> locations = new ArrayList<>();
 		collectValues(locations, attributes.get("resources"));
 		Assert.isTrue(!locations.isEmpty(),