Merge branch '2.6.x' into 2.7.x

Closes gh-29144
spring-projects · Dec 20, 2021 · 29ad847 · 29ad847
2 parents f4e28be + b3a304f
commit 29ad847
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 1 deletion.
diff --git a/...g-boot/src/main/java/org/springframework/boot/context/properties/bind/JavaBeanBinder.java b/...g-boot/src/main/java/org/springframework/boot/context/properties/bind/JavaBeanBinder.java
@@ -165,7 +165,8 @@ protected void addProperties(Method[] declaredMethods, Field[] declaredFields) {
 		private boolean isCandidate(Method method) {
 			int modifiers = method.getModifiers();
 			return !Modifier.isPrivate(modifiers) && !Modifier.isProtected(modifiers) && !Modifier.isAbstract(modifiers)
-					&& !Modifier.isStatic(modifiers) && !Object.class.equals(method.getDeclaringClass())
+					&& !Modifier.isStatic(modifiers) && !method.isBridge()
+					&& !Object.class.equals(method.getDeclaringClass())
 					&& !Class.class.equals(method.getDeclaringClass()) && method.getName().indexOf('$') == -1;
 		}
 

diff --git a/...t/src/test/java/org/springframework/boot/context/properties/bind/JavaBeanBinderTests.java b/...t/src/test/java/org/springframework/boot/context/properties/bind/JavaBeanBinderTests.java
@@ -318,6 +318,18 @@ void bindToInstanceWhenNoNestedShouldLeaveNestedAsNull() {
 		assertThat(bean.getValueBean()).isNull();
 	}
 
+	@Test
+	void bindToClassWithOverriddenPropertyShouldSetSubclassProperty() {
+		MockConfigurationPropertySource source = new MockConfigurationPropertySource();
+		source.put("foo.value-bean.int-value", "123");
+		source.put("foo.value-bean.sub-int-value", "456");
+		this.sources.add(source);
+		ExampleNestedSubclassBean bean = this.binder.bind("foo", Bindable.of(ExampleNestedSubclassBean.class)).get();
+		assertThat(bean.getValueBean()).isNotNull();
+		assertThat(bean.getValueBean().getIntValue()).isEqualTo(123);
+		assertThat(bean.getValueBean().getSubIntValue()).isEqualTo(456);
+	}
+
 	@Test
 	void bindToClassWhenPropertiesMissingShouldReturnUnbound() {
 		MockConfigurationPropertySource source = new MockConfigurationPropertySource();
@@ -804,6 +816,35 @@ String getFoo() {
 
 	}
 
+	static class ExampleNestedSubclassBean extends ExampleNestedBean {
+
+		private ExampleValueSubclassBean valueBean;
+
+		@Override
+		ExampleValueSubclassBean getValueBean() {
+			return this.valueBean;
+		}
+
+		void setValueBean(ExampleValueSubclassBean valueBean) {
+			this.valueBean = valueBean;
+		}
+
+		static class ExampleValueSubclassBean extends ExampleValueBean {
+
+			private int subIntValue;
+
+			int getSubIntValue() {
+				return this.subIntValue;
+			}
+
+			void setSubIntValue(int intValue) {
+				this.subIntValue = intValue;
+			}
+
+		}
+
+	}
+
 	static class ExampleWithNonDefaultConstructor {
 
 		private String value;