Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring Observability #1444

Closed
garyrussell opened this issue Mar 29, 2022 · 0 comments
Closed

Spring Observability #1444

garyrussell opened this issue Mar 29, 2022 · 0 comments
Labels
type: enhancement
Milestone
3.0.0-M4

Comments

@garyrussell
Copy link
Contributor

No description provided.

@garyrussell garyrussell added this to the 3.0.0-M3 milestone Mar 29, 2022
garyrussell added a commit that referenced this issue Mar 29, 2022
@garyrussell
GH-1444: Move to Micrometer Snapshots
6eca017 
#1444 Phase 0
@garyrussell garyrussell modified the milestones: 3.0.0-M3, 3.0.0-M4 May 16, 2022
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Sep 6, 2022
@garyrussell
spring-projectsGH-1444: Listener Observability Initial Commit
7b2c37f 
- expand scope to include error handler: spring-projects#1287
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Sep 6, 2022
@garyrussell
spring-projectsGH-1444: Listener Observability Initial Commit
6865003 
- expand scope to include error handler: spring-projects#1287
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Sep 6, 2022
@garyrussell
spring-projectsGH-1444: Listener Observability Initial Commit
faba0b0 
- expand scope to include error handler: spring-projects#1287
- tracing can't be used with a batch listener (multiple messages in listener call)
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Sep 7, 2022
@garyrussell
spring-projectsGH-1444: Listener Observability Initial Commit
15b04f0 
- expand scope to include error handler: spring-projects#1287
- tracing can't be used with a batch listener (multiple messages in listener call)
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Sep 13, 2022
@garyrussell
spring-projectsGH-1444: Listener Observability Initial Commit
6f35711 
- expand scope to include error handler: spring-projects#1287
- tracing can't be used with a batch listener (multiple messages in listener call)
garyrussell added a commit that referenced this issue Sep 19, 2022
@garyrussell @artembilan
GH-1444: Listener Observability Initial Commit (#1500)
66e5c11 
* GH-1444: Listener Observability Initial Commit

- expand scope to include error handler: #1287
- tracing can't be used with a batch listener (multiple messages in listener call)

* Rename Sender/Receiver contexts and other PR review comments.

* Rename contexts to Rabbit...; supply default KeyValues via the conventions.

* Javadoc polishing.

* Don't add default KV to high-card KVs.

* Fix previous commit.

* Fix contextual name (receiver side).

* Fix checkstyle.

* Polish previous commit.

* Fix contextual name (sender side)

* Remove contextual names from observations.

* Fix checkstyle.

* Remove customization of KeyValues from conventions.

* Add `getDefaultConvention()` to observations.

* Fix since 3.0.

* Support wider convention customization.

* Convention type safety.

* Fix Test - not sure why PR build succeeded.

* Add Meters to ObservationTests.

* Fix checkstyle.

* Make INSTANCE final.

* Add integration test.

* Test all available integrations.

* Remove redundant test code.

* Move getContextualName to conventions.

* Add docs.

* Fix doc link.

Co-authored-by: Artem Bilan <abilan@vmware.com>

* Remove unnecessary method overrides; make tag names more meaningful.

* Move getName() from contexts to conventions.

* Fix Race in Test

* Fix Race in Test.

Co-authored-by: Artem Bilan <abilan@vmware.com>
garyrussell added a commit that referenced this issue Sep 19, 2022
@garyrussell
GH-1444: Remove Unused Field from Test
57276fc
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Oct 3, 2022
@garyrussell
spring-projectsGH-1444: Observablility Documentation, Polish
8e3c24c 
Refactor for latest snapshots; add documentation generation.
Use NOOP registry and supplier for context.

Also fix class tangles.

Resolves spring-projects#1507

Disable auto doc generation and polish manually.
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Oct 6, 2022
@garyrussell
spring-projectsGH-1444: Observablility Documentation, Polish
55ba2a4 
Refactor for latest snapshots; add documentation generation.
Use NOOP registry and supplier for context.

Also fix class tangles.

Resolves spring-projects#1507

Disable auto doc generation and polish manually.
artembilan pushed a commit that referenced this issue Oct 6, 2022
@garyrussell
GH-1444: Observablility Documentation
639eb16 
Resolves #1507

Refactor for latest snapshots; add documentation generation.
Use NOOP registry and supplier for context.

Also fix class tangles.

Disable auto doc generation and polish manually.

* Fix observation of batch listeners; disable more tests temporarily.

* Add remoteServiceName to contexts; fix race in test.

* Add tests for remoteServiceName.

* Set the service name instead of overriding the getter.

* Re-enable tests.

* Switch to Spring Snapshots, Revert "Re-enable tests."

This reverts commit e0a80e3.

* Disable logback adjuster.

* Disable logback appender tests.
@artembilan artembilan mentioned this issue Oct 10, 2022
Closed
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Oct 20, 2022
@garyrussell
spring-projectsGH-1444: Observation Doc Gen Polishing
1f3a061 
- single task for spans and metrics
- always gen and remove packages from file names
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Oct 20, 2022
@garyrussell
spring-projectsGH-1444: Observation Doc Gen Polishing
a20d58a 
- single task for spans and metrics
- always gen and remove packages from file names
artembilan pushed a commit that referenced this issue Oct 21, 2022
@garyrussell
GH-1444: Observation Doc Gen Polishing
36e98a7 
- single task for spans and metrics
- always gen and remove packages from file names

* Fix link in What's New; add observation properties to container factory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
3.0.0-M4
Development

No branches or pull requests
1 participant
@garyrussell