New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trace information is missing when Exception is thrown from RabbitListener methods #1306
Comments
Is the work around I provided in spring-cloud/spring-cloud-sleuth#1660 (comment) not satisfactory for some reason? |
@garyrussell You mean not fixing this but asking the users to apply the workaround? |
See my comment in your PR: #1287 (comment) We can't apply your change or consider as a bug, since it works like that for any existing |
As we discussed on the PR, we can't make a breaking change in a patch release; we can schedule this for 2.4 (but there is currently no schedule for that at this time). We have the open PR, but I will set the milestone for this to 2.4. |
OK, sorry. I see you have created a similar issue for Spring Kafka: spring-projects/spring-kafka#1704. Perhaps we also need to create a similar one for a |
I'm not pushing for that draft PR, I'm manually transferring issues to the right place since GH can't do it across orgs, here are the others:
|
I think I would prefer to add a new We have a similar existing interceptor in spring-kafka (but it needs enhancing to support Sleuth). This would have the benefit of (a) not being a breaking change and (b) can be back-ported to earlier supported versions. It would, of course, need a change in sleuth to implement the new interceptor instead of adding the advice. |
Probably under the same category, tracing information is missing when there is a slow consumer & the response is received on client side after the configured timeout:
The equivalent issue reported in spring-cloud-sleuth is 1825. |
I don't believe it is related - the reply comes back on a different thread (dedicated for replies) so there is no tracing context over there; only on the thread that timed out. |
Is that how it works? Apologies, I debugged this a very long time ago, so my memory of it is a bit rusty, but I guess it makes sense. |
Right; yes, I was just thinking about the thread locals on the requestor thread; of course, the trace headers should be present in the reply and stored for the reply thread, but the template rejects the reply and by the time we hit the error handler, the headers are gone. Sorry for the noise. |
isn't this fixed now via: #1444? |
Affects Version(s): All currently supported versions (including
2.3.4
)Bug report
The issue was originally reported for Spring Cloud Sleuth but it seems it is not a Sleuth issue (and I can't transfer issues across orgs) so I'm opening this one to track it at the right place.
The original issue is this: spring-cloud/spring-cloud-sleuth#1660 opened by @goober
It contains the necessary details to understand what is going on, a sample project that reproduces the issue, some investigation details, a workaround, and a proposed fix (which is a breaking change):
The original sample project uses
spring-boot
2.3.0.RELEASE
that brings inspring-amqp
2.2.6.RELEASE
but the issue must be present in the latestspring-amqp
too (2.3.4
).Sample project: https://github.com/goober/spring-sleuth-rabbit-bug
Investigation details: spring-cloud/spring-cloud-sleuth#1660 (comment)
Proposed workaround: spring-cloud/spring-cloud-sleuth#1660 (comment)
Possible fix (breaking change): #1287
The text was updated successfully, but these errors were encountered: