Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds GemFireVectorStore Auto-Configuration #638

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adds GemFireVectorStore Auto-Configuration #638

wants to merge 1 commit into from

Conversation

luissson
Copy link

  • Adds spring boot auto-configuration support for GemFireVectorStore
  • Adds integration test GemFireVectorStoreAutoConfigurationIT
  • Includes gemfire-testcontainers in integration tests
  • Adds unit test GemFireVectorStorePropertiesTests
  • Refactors GemFireVectorStore.java extracting GemFireVectorStoreConfig.java
  • Renames spring-ai-gemfire to spring-ai-gemfire-store
  • Adds GemFireConnectionDetails
  • Adds GemFireVectorStoreProperties with default values

Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:

  • Sign the contributor license agreement
  • Rebase your changes on the latest main branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission

@tzolov tzolov added this to the 1.0.0-M1 milestone Apr 26, 2024
@tzolov tzolov added enhancement New feature or request vectors store labels Apr 26, 2024
@markpollack
Copy link
Member

I can't build this due to the error

[ERROR] Failed to execute goal on project spring-ai-gemfire-store: Could not resolve dependencies for project org.springframework.ai:spring-ai-gemfire-store:jar:1.0.0-SNAPSHOT: Failed to collect dependencies at com.vmware.gemfire:gemfire-testcontainers:jar:2.0.0: Failed to read artifact descriptor for com.vmware.gemfire:gemfire-testcontainers:jar:2.0.0: Could not transfer artifact com.vmware.gemfire:gemfire-testcontainers:pom:2.0.0 from/to gemfire-release-repo (https://commercial-repo.pivotal.io/data3/gemfire-release-repo/gemfire): authentication failed for https://commercial-repo.pivotal.io/data3/gemfire-release-repo/gemfire/com/vmware/gemfire/gemfire-testcontainers/2.0.0/gemfire-testcontainers-2.0.0.pom, status: 401 Unauthorized -> [Help 1]
[ERROR]

@luissson
Copy link
Author

luissson commented May 2, 2024

I can't build this due to the error

[ERROR] Failed to execute goal on project spring-ai-gemfire-store: Could not resolve dependencies for project org.springframework.ai:spring-ai-gemfire-store:jar:1.0.0-SNAPSHOT: Failed to collect dependencies at com.vmware.gemfire:gemfire-testcontainers:jar:2.0.0: Failed to read artifact descriptor for com.vmware.gemfire:gemfire-testcontainers:jar:2.0.0: Could not transfer artifact com.vmware.gemfire:gemfire-testcontainers:pom:2.0.0 from/to gemfire-release-repo (https://commercial-repo.pivotal.io/data3/gemfire-release-repo/gemfire): authentication failed for https://commercial-repo.pivotal.io/data3/gemfire-release-repo/gemfire/com/vmware/gemfire/gemfire-testcontainers/2.0.0/gemfire-testcontainers-2.0.0.pom, status: 401 Unauthorized -> [Help 1]
[ERROR]

For the integration tests, 'gemfire-testcontainers' is pulled in from GemFire's commercial maven repository.
To access you'll need valid credentials with an entry in .m2/settings.xml as shown here https://docs.vmware.com/en/VMware-GemFire/10.1/gf/getting_started-installation-obtain_gemfire_maven.html

@markpollack
Copy link
Member

markpollack commented May 2, 2024 •
edited

That web page times out and does not load

@geetrawat @luissson
Adds GemFireVectorStore Auto-Configuration
179684d 
- Adds spring boot auto-configuration support for GemFireVectorStore
- Adds integration test GemFireVectorStoreAutoConfigurationIT
- Includes gemfire-testcontainers in integration tests
- Adds unit test GemFireVectorStorePropertiesTests
- Refactors GemFireVectorStore.java extracting GemFireVectorStoreConfig.java
- Renames spring-ai-gemfire to spring-ai-gemfire-store
- Adds GemFireConnectionDetails
- Adds GemFireVectorStoreProperties with default values

Co-authored-by: Louis Jacome <louis.jacome@broadcom.com>
Co-authored-by: Jason Huyn <jason.huynh@broadcom.com>
@luissson
Copy link
Author

Force-pushed to resolve recent merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@markpollack markpollack

Labels
enhancement New feature or request vectors store
Projects
None yet
Milestone
1.0.0-M1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@luissson @markpollack @tzolov @geetrawat