Sets up MicrometerCapabilities #754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -45,7 +45,7 @@ public boolean processArgument(AnnotatedParameterContext context, Annotation ann | |||
| MethodMetadata metadata = context.getMethodMetadata(); | |||
| if (metadata.queryMapIndex() == null) { | |||
| metadata.queryMapIndex(paramIndex); | |||
| metadata.queryMapEncoded(SpringQueryMap.class.cast(annotation).encoded()); | |||
| // metadata.queryMapEncoded(SpringQueryMap.class.cast(annotation).encoded()); | |||
There was a problem hiding this comment.
This is no longer there in 11.10-SNAPSHOT
jonatan-ivanov
approved these changes
Sep 19, 2022
| @@ -243,8 +244,10 @@ protected static class MetricsConfiguration { | |||
|
|
|||
| @Bean | |||
| @ConditionalOnMissingBean | |||
| public MicrometerCapability micrometerCapability(MeterRegistry meterRegistry) { | |||
| return new MicrometerCapability(meterRegistry); | |||
| public MicrometerCapability micrometerCapability(MeterRegistry meterRegistry, | |||
There was a problem hiding this comment.
I'm thinking if we should add flags so that users can switch back to the MicrometerCapability if they want the old behavior.
marcingrzejszczak
force-pushed
the
micrometerObservationsViaFeignCapabilities
branch
from
d280d23
to
d8c9f2b
Compare
|
Closing as the corresponding feature has already been added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prerequisite - OpenFeign/feign#1760
sample - micrometer-metrics/micrometer-samples@7485ae5