Skip to content

Commit

Permalink
Re-enables tests due to boot test env ordering issue
Browse files Browse the repository at this point in the history
Fixes gh-4048
  • Loading branch information
spencergibb committed Nov 29, 2021
1 parent ed3834f commit dc67500
Showing 1 changed file with 0 additions and 6 deletions.
Expand Up @@ -27,7 +27,6 @@
import com.netflix.eureka.cluster.PeerEurekaNodes;
import com.netflix.eureka.registry.PeerAwareInstanceRegistry;
import com.netflix.eureka.resources.ServerCodecs;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import org.springframework.beans.factory.annotation.Autowired;
Expand Down Expand Up @@ -89,7 +88,6 @@ void notUpdatedWhenDnsIsTrue() {
}

@Test
@Disabled("boot env ordering see https://github.com/spring-cloud/spring-cloud-netflix/issues/4048")
void updatedWhenDnsIsFalse() {
changeProperty("eureka.client.use-dns-for-fetching-service-urls=false",
"eureka.client.region=unavailable-region", // to force defaultZone
Expand Down Expand Up @@ -119,7 +117,6 @@ void updatedWhenRegionChanged() {
}

@Test
@Disabled("boot env ordering see https://github.com/spring-cloud/spring-cloud-netflix/issues/4048")
void updatedWhenAvailabilityZoneChanged() {
changeProperty("eureka.client.use-dns-for-fetching-service-urls=false", "eureka.client.region=region4",
"eureka.client.availability-zones.region3=region3-zone",
Expand Down Expand Up @@ -175,7 +172,6 @@ void peerEurekaNodesIsRefreshablePeerEurekaNodes() {
}

@Test
@Disabled("boot env ordering see https://github.com/spring-cloud/spring-cloud-netflix/issues/4048")
void serviceUrlsCountAsSoonAsRefreshed() {
changeProperty(
"eureka.client.service-url.defaultZone=https://defaul-host3:8678/eureka/,http://defaul-host4:8678/eureka/");
Expand All @@ -185,7 +181,6 @@ void serviceUrlsCountAsSoonAsRefreshed() {
}

@Test
@Disabled("boot env ordering see https://github.com/spring-cloud/spring-cloud-netflix/issues/4048")
void serviceUrlsValueAsSoonAsRefreshed() {
changeProperty("eureka.client.service-url.defaultZone=https://defaul-host4:8678/eureka/");
forceUpdate();
Expand All @@ -194,7 +189,6 @@ void serviceUrlsValueAsSoonAsRefreshed() {
}

@Test
@Disabled("boot env ordering see https://github.com/spring-cloud/spring-cloud-netflix/issues/4048")
void dashboardUpdatedAsSoonAsRefreshed() {
changeProperty("eureka.client.service-url.defaultZone=https://defaul-host5:8678/eureka/");
forceUpdate();
Expand Down

0 comments on commit dc67500

Please sign in to comment.