support logger group when refresh by the /refresh endpoint #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p and refreshing the logger group definition when refreshed through refresh endpoint
…ed logger will use root logger level, and then if changed the root level from configuration, the removed logger level will be change.
…ed logger will use root logger level, and then if changed the root level from configuration, the removed logger level will be change.
|
@xfrogcn Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@xfrogcn Thank you for signing the Contributor License Agreement! |
|
The constructor change is a breaking change, meaning this wouldn't be able to be included until next year. It seems like some of the changes go beyond groups |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implement of LoggingRebinder , when refreshed by the /refresh endpoint, only changes the level of specific loggers and does not yet support changes the level of logger groups.
This pull request adds support for logger groups in LoggingRebinder, including: