Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect dynamic mgmt port. Fixes gh-561 #562

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chriswhite199
Copy link
Contributor

Ignoring the checkstyle auto-fixed whitespace changes, see:

  • spring-cloud-commons/src/main/java/org/springframework/cloud/client/serviceregistry/AbstractAutoServiceRegistration.java - Capture management web server init event & wait for ApplicationReadyEvent before starting registration (to ensure that http & optional mgmt ports have been discovered)
  • spring-cloud-commons/src/test/java/org/springframework/cloud/client/serviceregistry/AbstractAutoServiceRegistrationMgmtDisabledTests.java - updated correct property for mgmt port
  • spring-cloud-commons/src/test/java/org/springframework/cloud/client/serviceregistry/AbstractAutoServiceRegistrationTests.java - updated correct property for mgmt port

@spencergibb
Copy link
Member

I'm afraid we need to revert all the formatting changes

@chriswhite199
Copy link
Contributor Author

@spencergibb - so what am i doing wrong when running mvn install, as that appears to be the cause of the re-formatting. I'll revert the whitespace changes

@spencergibb
Copy link
Member

Nothing wrong. We just need to apply the formatting separately.

@spencergibb
Copy link
Member

Reverted via 4995ffc.

In spring-cloud-consul, tests started failing as start() was called before bind().

@lmove

This comment was marked as off-topic.

@spencergibb

This comment was marked as resolved.

@lmove

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide deterministic behavior when management.server.port=0
4 participants