Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove obsolete SpringFactoriesLoader#loadFactoryNames #1303

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: Remove obsolete SpringFactoriesLoader#loadFactoryNames #1303

wants to merge 1 commit into from

Conversation

livk-cloud
Copy link

@livk-cloud livk-cloud commented Nov 30, 2023 •
edited

  • Use ImportCandidates#load instead of SpringFactoriesLoader#loadFactoryNames
  • Use EnvironmentPostProcessorsFactory#getEnvironmentPostProcessors instead of SpringFactoriesLoader#loadFactoryNames

There is currently no better way to use SpringFactoriesLoader#loadFactoryNames in org.springframework.cloud.commons.util.SpringFactoryImportSelector#selectImports.
This may not necessarily produce better results, but isn't it a better thing to remove these obsolete methods
I hope the Spring Cloud team will come up with a better opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
waiting-for-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@livk-cloud @spring-cloud-issues