Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty keystore in SSLContextFactory. Fixes #1183 #1188

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow empty keystore in SSLContextFactory. Fixes #1183 #1188

wants to merge 1 commit into from

Conversation

freafrea
Copy link

@freafrea freafrea commented Jan 8, 2023

Fixes #1183

@spencergibb
Copy link
Member

Can you add a test?

@freafrea
Copy link
Author

freafrea commented Jan 9, 2023

Sure, although this class did not have any test that I could find so it might take me a while to understand how to write it in order to be consistent with other tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSLContextFactory should allow for no key store
4 participants
@freafrea @spencergibb @ryanjbaxter @spring-cloud-issues