Improve readability of method "isRetryException" #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "isRetryExhausted" check only depends on the throwable itself. The new code makes this more clear because the check is no longer part of anyMatch's lambda expression. I also extracted the method "isInstanceOfRetryType" because it makes it obvious that we do the same check on the throwable itself and its cause.
stefanbirkner
commented
Jan 6, 2022
| } | ||
|
|
||
| private boolean isInstanceOfRetryType(Throwable throwable) { | ||
| return typesThatTriggerRetry.stream().anyMatch(type -> type.isInstance(throwable)); |
There was a problem hiding this comment.
I would like to replace it with
Suggested change
| return typesThatTriggerRetry.stream().anyMatch(type -> type.isInstance(throwable)); | |
| return throwable instanceof IOException | |
| || throwable instanceof TimeoutException | |
| || throwable instanceof RetryableStatusCodeException; |
because it is simpler and it moves the information about the types close to where they are used. For me that makes the code easier to read. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "isRetryExhausted" check only depends on the throwable itself. The
new code makes this more clear because the check is no longer part of
anyMatch's lambda expression. I also extracted the method
"isInstanceOfRetryType" because it makes it obvious that we do the same
check on the throwable itself and its cause.