Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSLContextFactory should allow for no key store #1183

Open
freafrea opened this issue Dec 21, 2022 · 2 comments · May be fixed by #1188
Open

SSLContextFactory should allow for no key store #1183

freafrea opened this issue Dec 21, 2022 · 2 comments · May be fixed by #1188
Labels
enhancement help wanted

Comments

@freafrea
Copy link

I am using 3.1.4. My spring cloud config server has a self signed cert. I did not want to add its certificate to java trust store, so I wanted to use TlsProperties to provide the trust store. I can't do that without providing the keystore.

Currently the trust store is optional, I think the keystore needs to be optional too, as not always we need to use ssl client verification.

I can made a PR with the change, but I am not sure if removing this requirement in a straightforward way is OK for you.
@ryanjbaxter
Copy link
Contributor

PR is welcome

freafrea added a commit to freafrea/spring-cloud-commons that referenced this issue Jan 8, 2023
@freafrea
Allow empty keystore in SSLContextFactory. Fixes spring-cloud#1183
f2f9b5c
@freafrea freafrea linked a pull request Jan 8, 2023 that will close this issue
Open
@freafrea
Copy link
Author

freafrea commented Jan 8, 2023

I've added the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow empty keystore in SSLContextFactory. Fixes #1183 freafrea/spring-cloud-commons
3 participants
@ryanjbaxter @freafrea @spring-cloud-issues