Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

Refine Spring Integration support #1311

Closed
wants to merge 1 commit into from

Conversation

artembilan
Copy link
Contributor

Fixes #1134

Fixes spring-attic#1134

* Upgrade sample to the latest Spring Integration `5.5.7-SNAPSHOT`
* Add `maven-shade-plugin` and `native-maven-plugin` under Windows profile
to make native image build working on Windows.
Se more info in Native Build Tools docs:
https://graalvm.github.io/native-build-tools/latest/maven-plugin.html#long_classpath_and_shading_support
This profile simply can go to the `../maven-parent/pom.xml` to make all the samples working on Windows.
Or you can remove this on merge since it might be just a noise for a broader community
* Add custom `ReactorClientHttpConnector` bean into the sample app, since by default a DNS resolver
fails with NPE on Windows in native image.
See more info in the: spring-projects/spring-framework#27749
* Add more type nints into the `IntegrationHints`
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 29, 2021
@sdeleuze
Copy link
Contributor

sdeleuze commented Nov 30, 2021

Thanks @artembilan, is Spring Integration 5.5.7-SNAPSHOT required or are we fine with 5.5.6 shipped with Spring Boot 2.6.1 and used with Spring Native 0.11.0. If 5.5.7-SNAPSHOT I think I will move integration support to Spring Native 0.11.1 to be released in a few weeks (but we can still merge this PR asap).

@sdeleuze sdeleuze self-requested a review November 30, 2021 14:24
@artembilan
Copy link
Contributor Author

Thanks, @sdeleuze , for review!

Well, even if Spring Boot 2.6.1 was not planned ahead to let us slip into with our releases as well, and even if Spring Boot 2.6.2 is still not planned, that fully doesn't mean we cannot merge this:

  1. The fix for IntegrationHints is version independent.
  2. The fix for sample contains proper version.
  3. When we merge this and give it end-users, what they only would need to do is to have the same <spring-integration.version>5.5.7-SNAPSHOT</spring-integration.version> in their projects for time being.

Not sure if you have anything else in project to say what is supported and what is not, but I don't see obstacles to have this fix in the upcoming 0.11.0 release.

@sdeleuze
Copy link
Contributor

Yeah I agree, I will merge a subset of this PR, thanks!

@sdeleuze
Copy link
Contributor

Merged via 13272e9, good progresses!

@sdeleuze sdeleuze closed this Nov 30, 2021
@sdeleuze sdeleuze added type: compatibility Native image compatibility issue and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 30, 2021
@snicoll snicoll changed the title GH-1134: Restore Spring Integration support Refine Spring Integration support Nov 30, 2021
@sdeleuze
Copy link
Contributor

Feedback on the elements not integrated:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: compatibility Native image compatibility issue
Development

Successfully merging this pull request may close these issues.

Restore Spring Integration support
3 participants