Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

Improve Windows support documentation #1319

Closed
sdeleuze opened this issue Nov 30, 2021 · 3 comments
Closed

Improve Windows support documentation #1319

sdeleuze opened this issue Nov 30, 2021 · 3 comments
Assignees
Labels
type: documentation A documentation task
Milestone

Comments

@sdeleuze
Copy link
Contributor

  • Maven parent pom should probably updated to provide support for long commend lines, see related PR from @artembilan
  • Documentation should be updated accordingly
  • Shaded JAR support should be tested on the CI even if running on Linux
  • To be discussed with @snicoll : for start.spring.io, do we generate that in the pom.xml or do we just document that in HELP.md
@sdeleuze sdeleuze added the type: task A general task label Nov 30, 2021
@sdeleuze sdeleuze added this to the 0.11.1 milestone Nov 30, 2021
@sdeleuze sdeleuze self-assigned this Nov 30, 2021
@artembilan
Copy link
Contributor

Here is official Native Build Tools docs about Windows support: https://graalvm.github.io/native-build-tools/latest/maven-plugin.html#long_classpath_and_shading_support.

Another Windows issue comes from Netty and its default AddressResolverGroup against DNS from JNDI.
See more info here: spring-projects/spring-framework#27749.
When that one is fixed in the next Spring Framework version, the end-user still needs to add this bean into his/her project:

	@Bean
	ReactorNettyHttpClientMapper reactorNettyHttpClientMapper() {
		return httpClient -> httpClient.resolver(DefaultAddressResolverGroup.INSTANCE);
	}

That's for now.
Probably better to have a fix for DSN resolution in native images on Windows in Netty by itself.
Or even GraalVM should do something with the DSN and JNDI for Windows since everything works out-of-the-box on regular JVM or other OSs.

@sdeleuze sdeleuze modified the milestones: 0.11.1, 0.11.2 Dec 17, 2021
@jvalkeal
Copy link

jvalkeal commented Jan 9, 2022

I hit a same issue when I tried native builds on github actions as it makes it easy to build on windows. I suppose @artembilan workaround changes call path as I looked windows sources and NPE comes because some jdk windows native code doesn't initialise variable:

https://github.com/openjdk/jdk/blob/da75f3c4ad5bdf25167a3ed80e51f567ab3dbd01/src/java.base/windows/classes/sun/net/dns/ResolverConfigurationImpl.java#L101

Feels very much an issue in graal itself. Should we create an issue there as I didn't find anything similar from graal issues?

@sdeleuze
Copy link
Contributor Author

@artembilan @jvalkeal Please raise the Netty DNS issue on https://github.com/oracle/graal/issues.

@sdeleuze sdeleuze changed the title Improve Windows support in documentation and samples Improve Windows support documentation Jan 24, 2022
@sdeleuze sdeleuze added type: documentation A documentation task and removed type: task A general task labels Jan 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: documentation A documentation task
Development

No branches or pull requests

3 participants