Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify check for existing token #765

Merged
merged 2 commits into from Jan 3, 2022
Merged

Simplify check for existing token #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16cea19
Simplify check for existing token in RedisCacheHandler
ENT8R Jan 3, 2022
16b2df8
Update CHANGELOG.md
ENT8R Jan 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* Added `RedisCacheHandler`, a cache handler that stores the token info in Redis.
* Changed URI handling in `client.Spotify._get_id()` to remove qureies if provided by error.
* Added a new parameter to `RedisCacheHandler` to allow custom keys (instead of the default `token_info` key)
* Simplify check for existing token in `RedisCacheHandler`

## [2.19.0] - 2021-08-12

Expand Down
5 changes: 3 additions & 2 deletions spotipy/cache_handler.py
View file
Open in desktop
Expand Up @@ -166,8 +166,9 @@ def __init__(self, redis, key=None):
def get_cached_token(self):
token_info = None
try:
if self.redis.exists(self.key):
token_info = json.loads(self.redis.get(self.key))
token_info = self.redis.get(self.key)
if token_info:
return json.loads(token_info)
except RedisError as e:
logger.warning('Error getting token from cache: ' + str(e))

Expand Down