Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RedisCacheHandler #747

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
Expand Up @@ -7,7 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

// Add your changes here and then delete this line
### Added
* Added `RedisCacheHandler`, a cache handler that stores the token info in Redis.

## [2.19.0] - 2021-08-12

Expand Down
5 changes: 5 additions & 0 deletions docs/index.rst
Expand Up @@ -231,6 +231,11 @@ The custom cache handler would need to be a class that inherits from the base
cache handler ``CacheHandler``. The default cache handler ``CacheFileHandler`` is a good example.
An instance of that new class can then be passed as a parameter when
creating ``SpotifyOAuth``, ``SpotifyPKCE`` or ``SpotifyImplicitGrant``.
The following handlers are available and defined in the URL above.
- ``CacheFileHandler``
- ``MemoryCacheHandler``
- ``DjangoSessionCacheHandler``
- ``RedisCacheHandler``

Feel free to contribute new cache handlers to the repo.

Expand Down
1 change: 1 addition & 0 deletions setup.py
Expand Up @@ -26,6 +26,7 @@
author_email="paul@echonest.com",
url='https://spotipy.readthedocs.org/',
install_requires=[
'redis>=3.5.3',
'requests>=2.25.0',
'six>=1.15.0',
'urllib3>=1.26.0'
Expand Down
38 changes: 37 additions & 1 deletion spotipy/cache_handler.py
@@ -1,11 +1,18 @@
__all__ = ['CacheHandler', 'CacheFileHandler', 'DjangoSessionCacheHandler', 'MemoryCacheHandler']
__all__ = [
'CacheHandler',
'CacheFileHandler',
'DjangoSessionCacheHandler',
'MemoryCacheHandler',
'RedisCacheHandler']

import errno
import json
import logging
import os
from spotipy.util import CLIENT_CREDS_ENV_VARS

from redis import RedisError

logger = logging.getLogger(__name__)


Expand Down Expand Up @@ -138,3 +145,32 @@ def save_token_to_cache(self, token_info):
self.request.session['token_info'] = token_info
except Exception as e:
logger.warning("Error saving token to cache: " + str(e))


class RedisCacheHandler(CacheHandler):
"""
A cache handler that stores the token info in the Redis.
"""

def __init__(self, redis):
"""
Parameters:
* redis: Redis object provided by redis-py library
(https://github.com/redis/redis-py)
"""
self.redis = redis

def get_cached_token(self):
token_info = None
try:
token_info = json.loads(self.redis.get('token_info'))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't self.redis.get('token_info') be None if the value hasn't yet been stored in Redis and then json.loads(None) throw an exception?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Findus23
You're right. I'm sorry for that. I'll fix it.

except RedisError as e:
logger.warning('Error getting token from cache: ' + str(e))

return token_info

def save_token_to_cache(self, token_info):
try:
self.redis.set('token_info', json.dumps(token_info))
except RedisError as e:
logger.warning('Error saving token to cache: ' + str(e))