Added MemcacheCacheHandler #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need your thoughts on this because I've never heard of memcache. Is it popular? And does it make sense to use with spotipy? |
There was a problem hiding this comment.
Memcache is widely used and just like the other cache handlers would allow to store the token somewhere else.
The new requirement is a problem, so perhaps we should move it to extras_require and update the installation instructions to look like https://stackoverflow.com/a/65936306/1515819
However we haven't done that for Redis. We could leave Redis where it is for now and move it to extras in v3 to maintain backward compatibility.
stephanebruckert
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a CacheHandler for Memcached using pymemcache.