Fork on java 9+ #150
Merged
Fork on java 9+ #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnorberg
force-pushed
the
fork-on-java-9+
branch
from
26eb417
to
c53e73f
Compare
danielnorberg
force-pushed
the
fork-on-java-9+
branch
from
c53e73f
to
4d6e00a
Compare
|
Yeah, I agree the warnings are not nice. It's a balance between warnings and the small extra overhead of forking. My original thought was to avoid forking, but lets go with the more reasonable avoiding unnecessary warnings :) |
danielnorberg
commented
Mar 29, 2022
| @@ -99,7 +99,7 @@ For example, you may prefer that the `check` goal is performed in an earlier pha | |||
|
|
|||
| `style` sets the formatter style to be `google` or `aosp`. By default this is `google`. Projects using Android conventions may prefer `aosp`. | |||
|
|
|||
| `forkMode` lets you specify whether to run google-java-format in a fork or in-process. Also adds JVM arguments when needed. Value `default` will fork when JDK 16+ is detected, `never` runs in-process, regardless of JDK version and `always` will always fork. | |||
| `forkMode` lets you specify whether to run google-java-format in a fork or in-process. Also adds JVM arguments to expose JDK internal javac APIs. Value `default` (which is the default) will fork (to avoid warnings for JDK9+ and to be able to run at all for JDK16+), `never` runs in-process, regardless of JDK version and `always` will always fork. | |||
klaraward
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#106