Fixed FindDeadLocalStores to handle LOOKUPSWITCH and TABLESWITCH #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThrawnCA
approved these changes
Apr 18, 2024
LOOKUPSWITCH and TABLESWITCH both extend Select, use the base class to detect the start of a switch in FindDeadLocalStores Updated the line numbers of expected bugs
gtoison
changed the title
hazendaz
approved these changes
Apr 21, 2024
gtoison
added a commit
to gtoison/spotbugs
that referenced
this pull request
May 6, 2024
When looking for a switch the instruction might be LOOKUPSWITCH or TABLESWITCH. Look for Select which is the base class for both. See spotbugs#2782 See spotbugs#2937
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Java switch might be compiled into a LOOKUPSWITCH or TABLESWITCH. The corresponding BCEL classes both extends Select so we can use that class for the test.