SER11-J. Prevent overwriting of externalizable objects #2426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrikScully
force-pushed
the
feature/SER11-J
branch
from
3d2a248
to
06266a9
Compare
ThrawnCA
reviewed
May 23, 2023
PatrikScully
force-pushed
the
feature/SER11-J
branch
from
7f2ef70
to
f422890
Compare
hazendaz
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extended the
SerializableIdiomdetector to checkreadExternal()function for the SER11-J bug.I created several test classes to make sure that every assigned class variable are need to be in an if condition. Also I checked that the variable in the if condition will get a new value. (so the initialized variable in the example changes value)
I ran the extended detector for some larger repositories like ElasticSearch, but I didn't get any false-positive finding.
Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code