Fix for Issue 2040 #2072
Open
Fix for Issue 2040 #2072
+431
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes issue spotbugs#2040 by limiting the errors reported by the detector `ThrowingExceptions` to cases where `java.lang.Exception` or `lava.lang.Throwable` appears in the exception specification of th method but it is neither inherited from an overridden method nor is is coming from another method that the method invokes. Syntathic methods are also omitted as well as methods which throw generic exceptions.
KengoTODA
requested changes
May 28, 2022
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/ThrowingExceptions.java
Show resolved
Hide resolved
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/ThrowingExceptions.java
Outdated
Show resolved
Hide resolved
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/ThrowingExceptions.java
Outdated
Show resolved
Hide resolved
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/ThrowingExceptions.java
Outdated
Show resolved
Hide resolved
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/ThrowingExceptions.java
Outdated
Show resolved
Hide resolved
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/ThrowingExceptions.java
Outdated
Show resolved
Hide resolved
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/ThrowingExceptions.java
Outdated
Show resolved
Hide resolved
added 4 commits
May 30, 2022 10:16
This PR fixes issue spotbugs#2040 by limiting the errors reported by the detector `ThrowingExceptions` to cases where `java.lang.Exception` or `lava.lang.Throwable` appears in the exception specification of th method but it is neither inherited from an overridden method nor is is coming from another method that the method invokes. Syntathic methods are also omitted as well as methods which throw generic exceptions.
KengoTODA
reviewed
May 30, 2022
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/ThrowingExceptions.java
Outdated
Show resolved
Hide resolved
KengoTODA
requested changes
May 30, 2022
added 3 commits
May 31, 2022 14:56
…e false-positives from the reports
|
Thank you for your comments, @KengoTODA. You were right in all of them. I fixed every one and also added new test cases. Although I tested this PR on several medium-size projects, something was probably wrong with my CI loop because the tests seemed to have passed which is wrong because they should have crashed. Now with the new test cases I could fix these issues. |
ThrawnCA
previously approved these changes
Sep 1, 2022
ThrawnCA
requested changes
Sep 5, 2022
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/ThrowingExceptions.java
Outdated
Show resolved
Hide resolved
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/ThrowingExceptions.java
Outdated
Show resolved
Hide resolved
ThrawnCA
requested changes
Sep 5, 2022
|
Thanks, @ThrawnCA! You have exceptionally good eyes for typos. |
baloghadamsoftware
requested review from
ThrawnCA
and removed request for
KengoTODA
baloghadamsoftware
requested review from
KengoTODA
and removed request for
ThrawnCA and
KengoTODA
ThrawnCA
approved these changes
May 2, 2023
|
@JuditKnoll I think that this PR got stuck in limbo when Kengo retired from the project, would you have time to review it? |
ThrawnCA
approved these changes
Aug 14, 2023
JuditKnoll
requested changes
Aug 16, 2023
There was a problem hiding this comment.
It would be great to see more testcases, for example:
- one similar to the first example in False positive for THROWS_METHOD_THROWS_CLAUSE_THROWABLE #2040, where there is an Exception throwing method in the lambda,
- one where a RuntimeException is thrown, but it's handled by catching the parent of it.
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/ThrowingExceptions.java
Outdated
Show resolved
Hide resolved
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/ThrowingExceptions.java
Outdated
Show resolved
Hide resolved
spotbugs-tests/src/test/java/edu/umd/cs/findbugs/detect/Issue2040Test.java
Outdated
Show resolved
Hide resolved
ThrawnCA
approved these changes
Aug 31, 2023
…N and THROWS_METHOD_THROWS_CLAUSE_THROWABLE
ThrawnCA
approved these changes
Oct 5, 2023
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
Throw fix
ThrawnCA
approved these changes
Oct 20, 2023
ThrawnCA
approved these changes
Oct 20, 2023
ThrawnCA
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #2040 by limiting the errors reported by the detector
ThrowingExceptionsto cases wherejava.lang.Exceptionorlava.lang.Throwableappears in the exception specification of th method but it is neitherinherited from an overridden method nor is is coming from another method that the method invokes. Syntethic
methods are also omitted as well as methods which throw generic exceptions.
Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code