Add java.lang.Class to known immutables #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storing a reference to a Class object triggers EI_EXPOSE_REP2, which is not really fair, as java.lang.Class is really immutable. Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
rovarga
force-pushed
the
class-is-immutable
branch
from
550252b
to
0e8847b
Compare
ThrawnCA
previously approved these changes
Sep 12, 2021
KengoTODA
approved these changes
Sep 12, 2021
ThrawnCA
approved these changes
Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing a reference to a Class object triggers EI_EXPOSE_REP2, which is
not really fair, as java.lang.Class is really immutable.
Signed-off-by: Robert Varga robert.varga@pantheon.tech
Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code