Issue 1025 #1112
Merged
Issue 1025 #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 30, 2020
Resolved XPathException generating html report if BugInstance contains multiple Class elements
#1102
Closed
|
Kudos, SonarCloud Quality Gate passed!
|
ThrawnCA
reviewed
Mar 30, 2020
| @@ -282,7 +282,7 @@ | |||
| <xsl:copy-of select="$bugTableHeader"/> | |||
| <xsl:apply-templates select="$warningSet"> | |||
| <xsl:sort select="@abbrev"/> | |||
| <xsl:sort select="Class/@classname"/> | |||
| <xsl:sort select="Class[1]/@classname"/> | |||
There was a problem hiding this comment.
Does this still work if there is only one element?
There was a problem hiding this comment.
I think yes. At least I see in our build that both single / multiple matches are working now.
I have not much experience with that, but stack overflow suggests this as a viable approach:
https://stackoverflow.com/questions/16928121/how-to-select-first-node-only-in-xslt
There was a problem hiding this comment.
@mkienenb , @paulk-asert : WDYT?
ThrawnCA
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code