Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated RV_01_TO_INT to include float and long #1851

Merged
merged 5 commits into from Dec 11, 2021

Conversation

heeki
Copy link
Contributor

@heeki heeki commented Dec 7, 2021

Added test class, unit test, and resolution for #1518.

Make sure these boxes are checked before submitting your PR -- thank you!

  • Added an entry into CHANGELOG.md if you have changed SpotBugs code

ThrawnCA
ThrawnCA previously approved these changes Dec 7, 2021
ThrawnCA
ThrawnCA previously approved these changes Dec 7, 2021
Copy link
Member

@KengoTODA KengoTODA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for suggesting this PR, and please do not forget updating CHANGELOG.md :)
It is also necessary to run ./gradlew spotlessApply to format your code.

@heeki
Copy link
Contributor Author

heeki commented Dec 8, 2021

I have updated changelog.md with the fix. Apologies on the last failed build. I had run ./gradle spotlessApply but had only committed one of the two files that were updated. I've included the second updated file in the last commit.

Copy link
Member

@KengoTODA KengoTODA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are LGTM. Please add and push your updated CHANGELOG.md.

Copy link
Member

@KengoTODA KengoTODA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution that makes our product and community advanced!

@KengoTODA KengoTODA merged commit 22fba92 into spotbugs:master Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants