False negatives on RV_01_TO_INT

[gloNelson]

Hi,
I found false negatives on RV_01_TO_INT when reading the source code of SpotBugs in line 1171 of DumbMethods.java

It seems that SpotBugs only checks for several APIs that generate a random value (Math.random() and nextDouble()) but omits the nextFloat() API that can be used for the same purpose.

However, I think that based on its bug description that "nextFloat()" is not mentioned as an exception, the pattern RV_01_TO_INT should provide more support to the method nextFloat().

Here is the demo,

void test(){
    Random random = new Random();
    float f = random.nextFloat() * num; // no warning (false negative)
}

[dejan2609]

@gloNelson what is your Spotbugs version ?

[gloNelson]

@dejan2609 Hi, it is the latest version of Spotbugs. Thank you for your reply.

[gtoison]

This was fixed by #1851