Resolved XPathException generating html report with default.xsl

See issue #1025: we had troubles to transorm if BugInstance contained multiple Class elements. This commit fixes default.xsl.
spotbugs · Mar 30, 2020 · e664446 · e664446
1 parent ce6b746
commit e664446
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,7 @@ Currently the versioning policy of this project follows [Semantic Versioning v2.
 * GUI was using older version of jdom2 compared to spotbugs in general, bumped it to match at 2.1.1
 * Numerous places in manifest, jnlp files, and sample analysis xml were indicating older asm that was already upgraded to 7.3.1, fixed
 * Added commons-text 1.8 which treats &#955; properly in xml as it is allowed as λ.  Associated test was corrected to use proper junit and &#955; was changed to λ.  The escape only was applicable to html.  Commons-lang original treatment was incorrect.
+* Resolved fatal exception in html report if BugInstance contains multiple Class elements ([#1025](https://github.com/spotbugs/spotbugs/issues/1025))
 
 ### Changed
 

diff --git a/spotbugs/src/xsl/default.xsl b/spotbugs/src/xsl/default.xsl
@@ -282,7 +282,7 @@
 		<xsl:copy-of select="$bugTableHeader"/>
 		<xsl:apply-templates select="$warningSet">
 			<xsl:sort select="@abbrev"/>
-			<xsl:sort select="Class/@classname"/>
+			<xsl:sort select="Class[1]/@classname"/>
 		</xsl:apply-templates>
 	</table>
 </xsl:template>