fix: FindReturnRef throws an IllegalArgumentException unexpectedly

IllegalArgumentException is thrown when CHECKCAST bytecode is used even when the operand stack is TOP. close #2019
spotbugs · Apr 19, 2022 · 2a569c7 · 2a569c7
1 parent c7f7c02
commit 2a569c7
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/spotbugs/src/main/java/edu/umd/cs/findbugs/detect/FindReturnRef.java b/spotbugs/src/main/java/edu/umd/cs/findbugs/detect/FindReturnRef.java
@@ -296,7 +296,7 @@ public void afterOpcode(int seen) {
             }
         }
 
-        if (seen == Const.CHECKCAST) {
+        if (seen == Const.CHECKCAST && !stack.isTop()) {
             OpcodeStack.Item item = stack.getStackItem(0);
             if (fieldCloneUnderCast != null) {
                 arrayFieldClones.put(item, fieldCloneUnderCast);