Run workflows even on Windows #643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In URL the Windows platform may use a short path, and it makes functional test unstable. It is also not useful for users, they need a full path but the printed URL is not.
KengoTODA
commented
Dec 10, 2021
.github/workflows/gradle.yml
Outdated
| SIGNING_PASSWORD: ${{ secrets.SIGNING_PASSWORD }} | ||
| run: | | ||
| ./gradlew build --no-daemon "-Dsnom.test.functional.gradle=${{ matrix.gradle }}" | ||
| - uses: actions/upload-artifact@v2.2.4 |
There was a problem hiding this comment.
This version is necessary to avoid a known problem in the latest release.
Refs actions/upload-artifact#281
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we introduced a defect that is caused only on the Windows platform (#614). We had a similar problem (#273) previously.
To avoid reproducing these problems, run workflows in PR not only the Ubuntu platform but also the Windows platform.
This PR changes the report path from URL to canonical file path, because, on the Windows platform URL and absolute path may include short paths and it makes functional test unstable.