use ffmpeg-sys-next, single version of bindgen #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One version is easier to keep track of and should reduce build times. * replace ffmpeg-sys with ffmpeg-sys-next, which (among other things) uses bindgen 0.64. ffmpeg-sys was using a pre-0.60 version, so in some of our call sites, it hit build errors on Rust 1.70 due to rust-lang/rust-bindgen#2083 https://github.com/rust-lang/rust-bindgen/blob/main/CHANGELOG.md#0600 * update cargo lock stuff to use the same version * remove stale comments about older versions
|
Hold off on reviewing for a minute. I tried using this and hit a problem with xilinx. Gonna see if I can easily make the CI actually build that to verify the fix / avoid introducing such problems again. |
scottlamb
force-pushed
the
update-deps
branch
7 times, most recently
from
3515705
to
4e22d36
Compare
|
Better now. I gave up for now on making xilinx build in CI (the SDK wants older versions of apt deps than the |
epingel2
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One version is easier to keep track of and should reduce build times.
replace ffmpeg-sys with ffmpeg-sys-next, which (among other things) uses bindgen 0.64. ffmpeg-sys was using a pre-0.60 version, so in some of our call sites, it hit build errors on Rust 1.70 due to
#[derive]is used on#[repr(packed)]struct that does not derive Copy (E0133) rust-lang/rust-bindgen#2083 https://github.com/rust-lang/rust-bindgen/blob/main/CHANGELOG.md#0600update cargo lock stuff to use the same version
remove stale comments about older versions