Update version, gemspec, and CHANGELOG for 2.8.2 #495
Merged
+22
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should be fine, directories are removed by RubyGems internally according to https://guides.rubygems.org/specification-reference/#files |
Ran `bundle exec rake gem:gemspec` on Ruby 3.2.1 to update the gemspec. Not sure why list of files changed, but it has happened before: sporkmonger#466 (comment) List extended this time with ["addressable.gemspec", "benchmark", "data", "gemfiles", "lib", "spec", "tasks"] Exclude `coverage` directory from files list as it is ignored by git.
Hmm, running |
|
Trying to correct it with #497 |
dentarg
added a commit
to dentarg/addressable
that referenced
this pull request
Aug 3, 2023
This should resolve the issues (sporkmonger#495, sporkmonger#497) with the files list once for all. The main problem was probably the "[A-Z]*" glob matching lowercase files (and directories) when using a case-insensitive filesystem (typical for macOS). Inspired by sporkmonger@0a6f091 Co-authored-by: Adrien Rey-Jarthon <jobs@adrienjarthon.com>
Merged
dentarg
added a commit
that referenced
this pull request
Aug 3, 2023
This should resolve the issues (#495, #497) with the files list once for all. The main problem was probably the "[A-Z]*" glob matching lowercase files (and directories) when using a case-insensitive filesystem (typical for macOS). Inspired by 0a6f091 Co-authored-by: Adrien Rey-Jarthon <jobs@adrienjarthon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran
bundle exec rake gem:gemspecon Ruby 3.2.1 to update the gemspec.Not sure why list of files changed, but it has happened before: #466 (comment)
List extended this time with
Changes: addressable-2.8.1...5c22f25