Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Addressable::URI.normalize_path, fix linter offenses #430

Merged
merged 2 commits into from Sep 25, 2021
Merged

Refactor Addressable::URI.normalize_path, fix linter offenses #430

merged 2 commits into from Sep 25, 2021

Conversation

Mifrill
Copy link
Contributor

@Mifrill Mifrill commented Aug 31, 2021 •
edited

  • refactor normalize_path method with loop-with-break recommendation
  • refactor normalize_path method with solve may be uninitialized IDE offenses
  • refactor normalize_path method with solve Style/RedundantReturn: Redundant return detected.

#319 (comment)

@Mifrill
Copy link
Contributor Author

Mifrill commented Sep 25, 2021

Hey @dentarg, thanks for the review, any chance to have it merged?

@dentarg dentarg changed the title Split pull#319: fix linter offenses in self.normalize_path Refactor Addressable::URI.normalize_path, fix linter offenses Sep 25, 2021
@dentarg dentarg merged commit f3fb80c into sporkmonger:main Sep 25, 2021
@Mifrill Mifrill deleted the refactor/split_pull#319 branch September 26, 2021 03:44
@Mifrill
Copy link
Contributor Author

Mifrill commented Sep 26, 2021

@dentarg Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dentarg dentarg dentarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mifrill @dentarg