Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Encodings before calling force_encoding in Addressable::URI #341

Merged
merged 7 commits into from Aug 18, 2022
Merged

Check Encodings before calling force_encoding in Addressable::URI #341

merged 7 commits into from Aug 18, 2022

Commits on Aug 31, 2021

  1. Check to see if @normalized_* variables are already UTF-8 before 

    calling force_encoding on them

This prevents unnecessary mutation of these variables when already set
and appropriately encoded. Necessary for our use case as we freeze our
Addressable::URI objects to ensure they don't get changed when passed around
    @ACBullen @baseballlover723
    ACBullen authored and baseballlover723 committed Aug 31, 2021
    Copy the full SHA
    2e08cef View commit details
    Browse the repository at this point in the history

  2. Implement tests to verify a deeply frozen URI doesn't mutate instance… 

    … variables unnecessarily
    @ACBullen @baseballlover723
    ACBullen authored and baseballlover723 committed Aug 31, 2021
    Copy the full SHA
    52c524b View commit details
    Browse the repository at this point in the history

  3. move forcing utf8 encoding into a helper function

    @baseballlover723
    baseballlover723 committed Aug 31, 2021
    Copy the full SHA
    8194318 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2021

  1. check against RuntimeError for Ruby < 2.5

    @baseballlover723
    baseballlover723 committed Sep 1, 2021
    Copy the full SHA
    02c6912 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2021

  1. Merge branch 'main' into alexb/check_before_force_encoding

    @baseballlover723
    baseballlover723 committed Sep 29, 2021
    Copy the full SHA
    ca5a303 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2022

  1. Merge branch 'main' into alexb/check_before_force_encoding

    @sporkmonger
    sporkmonger committed Jul 30, 2022
    Copy the full SHA
    781ee9a View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. update spec

    @baseballlover723
    baseballlover723 committed Aug 1, 2022
    Copy the full SHA
    b5e929b View commit details
    Browse the repository at this point in the history