Skip to content

Commit

Permalink
Fix template expand level 2 hash support for non-string objects (#499)
Browse files Browse the repository at this point in the history
Close #498
  • Loading branch information
jarthod committed Apr 4, 2023
1 parent bcaf766 commit c00d58b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 9 deletions.
9 changes: 3 additions & 6 deletions lib/addressable/template.rb
Expand Up @@ -896,19 +896,16 @@ def join_values(operator, return_value)
#
# @return [Hash, Array, String] The normalized values
def normalize_value(value)
unless value.is_a?(Hash)
value = value.respond_to?(:to_ary) ? value.to_ary : value.to_str
end

# Handle unicode normalization
if value.kind_of?(Array)
value.map! { |val| normalize_value(val) }
if value.respond_to?(:to_ary)
value.to_ary.map! { |val| normalize_value(val) }
elsif value.kind_of?(Hash)
value = value.inject({}) { |acc, (k, v)|
acc[normalize_value(k)] = normalize_value(v)
acc
}
else
value = value.to_s if !value.kind_of?(String)
if value.encoding != Encoding::UTF_8
value = value.dup.force_encoding(Encoding::UTF_8)
end
Expand Down
6 changes: 3 additions & 3 deletions spec/addressable/template_spec.rb
Expand Up @@ -209,7 +209,7 @@
:path => "/foo/bar",
:semi => ";",
:list => %w(red green blue),
:keys => {"semi" => ';', "dot" => '.', "comma" => ','}
:keys => {"semi" => ';', "dot" => '.', :comma => ','}
}
}
context "Expansion with value modifiers" do
Expand Down Expand Up @@ -404,7 +404,7 @@
{
:var => "value",
:semi => ";",
:year => %w(1965 2000 2012),
:year => [1965, 2000, 2012],
:dom => %w(example com)
}
}
Expand Down Expand Up @@ -437,7 +437,7 @@
:base => "http://example.com/home/",
:path => "/foo/bar",
:list => ["red", "green", "blue"],
:keys => {"semi" => ";","dot" => ".","comma" => ","},
:keys => {"semi" => ";","dot" => ".",:comma => ","},
:v => "6",
:x => "1024",
:y => "768",
Expand Down

0 comments on commit c00d58b

Please sign in to comment.