fix: delete in binding.py now same as get/post #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently you can not pass custom headers to delete, as they are overwritten with default self._auth_headers. Replaced that with all_headers as in get and put.
|
This change is required to leverage .delete using splunklib. Current work is blocked by this, as deletion is not possible without header authentication. Please have a look at this, or any other way we can expedite this. |
|
Saw in another PR wanting to solve the same thing, to add a test case. Where would you suggest I do that? In which testing file is this functionality tested usually? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you can not pass custom headers to delete, as they are overwritten with default self._auth_headers. Replaced that with all_headers as in get and put.