Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve thirdparty cookies #463

Merged
merged 2 commits into from Jun 13, 2022
Merged

Preserve thirdparty cookies #463

merged 2 commits into from Jun 13, 2022

Conversation

ashah-splunk
Copy link
Contributor

  • added cookies into the request header if thirdparty cookies exisits

@fantavlik fantavlik merged commit 27f8fbf into develop Jun 13, 2022
@fantavlik fantavlik mentioned this pull request Jun 13, 2022
@akaila-splunk akaila-splunk mentioned this pull request Jun 17, 2022
@bendikro
Copy link

bendikro commented Sep 7, 2022

Were the tests updated to ensure there won't be any regressions?

@ashah-splunk
Copy link
Contributor Author

@bendikro yes tests were updated in PR #449 as part of the fix for issue #438. As we cannot have a setup with a middleware on the CI test execution we do not have tests for the exact scenario instead we have test cases where some cookie exists but not the Splunk Auth Cookie and authentication is carried out using username and password. Here Username/Password can be substituted by either Session key or bearer token.

@ashah-splunk ashah-splunk deleted the preserve_thirdparty_cookies branch November 29, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants