Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow developers to choose the default view #1197

Merged
merged 13 commits into from
Jun 3, 2024

Conversation

artemrys
Copy link
Member

@artemrys artemrys commented May 15, 2024

Issue number: #1041

Summary

Changes

Please provide a summary of what's being changed

Configuration page require admin privileges and if a Splunk user is not an admin - configuration page will show an error which is confusing. This PR allows to set a default page to search so there will be no error shown when a Splunk user opens add-on for the first time.

This PR enables TA developers to choose the default view, one of four: inputs, configuration, dashboard and search.

User experience

Please describe what the user experience looks like before and after this change

Nothing changes for the existing customers. For customers who decide to use search view as a default one - they need to update their globalConfig file, specifically set meta.defaultView to search and rebuild an add-on.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

@artemrys artemrys marked this pull request as ready for review May 15, 2024 11:12
@artemrys artemrys requested review from a team as code owners May 15, 2024 11:12
Copy link
Contributor

@kkedziak-splunk kkedziak-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but wouldn't it be better to introduce a text parameter, where one could put a name of the default view? In case someone in the future asks for e.g. inputs being default?

@artemrys
Copy link
Member Author

LGTM but wouldn't it be better to introduce a text parameter, where one could put a name of the default view? In case someone in the future asks for e.g. inputs being default?

I am working on that right now.

@artemrys artemrys changed the title feat: allow to have search view as a default instead of configuration view feat: allow developers to choose the default view May 21, 2024
@artemrys artemrys merged commit 21610e2 into develop Jun 3, 2024
55 of 61 checks passed
@artemrys artemrys deleted the feat/default-nav-view branch June 3, 2024 13:16
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2024
@vtsvetkov-splunk
Copy link
Collaborator

55 of 61 checks passed

@artemrys are we alright?

@artemrys
Copy link
Member Author

artemrys commented Jun 3, 2024

55 of 61 checks passed

@artemrys are we alright?

we are not, so all-checks did not prevent us from merging this because I do not remember using admin powers

will work on a fix shortly

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants