Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pluggable storage] polishing #568

Open
wants to merge 10 commits into
base: pluggable_storage_baseline
Choose a base branch
from
Open

[Pluggable storage] polishing #568

wants to merge 10 commits into from

Conversation

EmilianoSanchez
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez commented Aug 11, 2021 •
edited

JS SDK

What did you accomplish?

  • Rename wrapper.close to wrapper.disconnect
  • Rename 'CUSTOM' type to 'PLUGGABLE' type
  • Fix typos

How do we test the changes introduced in this PR?

Extra Notes

@sonarqube-pull-requests
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@EmilianoSanchez EmilianoSanchez changed the base branch from pluggable_storage_baseline to development November 5, 2021 16:52
@EmilianoSanchez EmilianoSanchez changed the base branch from development to pluggable_storage_baseline November 22, 2021 21:42
@EmilianoSanchez EmilianoSanchez changed the title [Pluggable storage] polishing [WIP] [Pluggable storage] polishing Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmelograno mmelograno mmelograno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EmilianoSanchez @mmelograno