Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #804 from splitio/development
Release v1.26.0
- Loading branch information
Showing
59 changed files
with
1,091 additions
and
345 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| import sinon from 'sinon'; | ||
| import splitChangesMock1 from '../mocks/splitchanges.since.-1.semver.json'; | ||
|
|
||
| import { SplitFactory } from '../../'; | ||
|
|
||
| const listener = { | ||
| logImpression: sinon.stub() | ||
| }; | ||
|
|
||
| const config = { | ||
| core: { | ||
| authorizationKey: '<fake-token>', | ||
| key: 'emi@split.io' | ||
| }, | ||
| urls: { | ||
| sdk: 'https://sdk.evaluation-semver/api', | ||
| events: 'https://events.evaluation-semver/api' | ||
| }, | ||
| sync: { | ||
| impressionsMode: 'DEBUG' | ||
| }, | ||
| impressionListener: listener, | ||
| streamingEnabled: false | ||
| }; | ||
|
|
||
| export default async function (fetchMock, assert) { | ||
|
|
||
| fetchMock.getOnce(config.urls.sdk + '/splitChanges?s=1.1&since=-1', { status: 200, body: splitChangesMock1 }); | ||
| fetchMock.getOnce(config.urls.sdk + '/splitChanges?s=1.1&since=1675259356568', { status: 200, body: { splits: [], since: 1675259356568, till: 1675259356568 } }); | ||
| fetchMock.getOnce(config.urls.sdk + '/mySegments/emi%40split.io', { status: 200, body: { mySegments: [] } }); | ||
| fetchMock.getOnce(config.urls.sdk + '/mySegments/2nd', { status: 200, body: { mySegments: [] } }); | ||
|
|
||
| const splitio = SplitFactory(config); | ||
| const client = splitio.client(); | ||
|
|
||
| await client.ready(); | ||
|
|
||
| // EQUAL_TO_SEMVER matcher | ||
| assert.equal(client.getTreatment('semver_equalto', { 'version': '1.22.9' }), 'on', 'the rule will return `on` if attribute `version` is equal to `1.22.9`'); | ||
| assert.equal(client.getTreatment('semver_equalto', { 'version': '1.22.9+build' }), 'off', 'build metadata is not ignored'); | ||
| assert.equal(client.getTreatment('semver_equalto', { 'version': '1.22.9-rc.0' }), 'off', 'the rule will return `off` if attribute `version` is not equal to `1.22.9`'); | ||
| assert.equal(client.getTreatment('semver_equalto', { 'version': null }), 'off', 'the rule will return `off` if attribute `version` is not the expected type'); | ||
| assert.equal(client.getTreatment('semver_equalto'), 'off', 'the rule will return `off` if attribute `version` is not provided'); | ||
|
|
||
| // IN_LIST_SEMVER matcher | ||
| assert.equal(client.getTreatment('semver_inlist', { 'version': '2.1.0' }), 'on', 'the rule will return `on` if attribute `version` is in list (`1.22.9`, `2.1.0`)'); | ||
| assert.equal(client.getTreatment('semver_inlist', { 'version': '1.22.9' }), 'on', 'the rule will return `on` if attribute `version` is in list (`1.22.9`, `2.1.0`)'); | ||
| assert.equal(client.getTreatment('semver_inlist', { 'version': '1.22.9+build' }), 'off', 'build metadata is not ignored'); | ||
| assert.equal(client.getTreatment('semver_inlist', { 'version': '1.22.9-rc.0' }), 'off', 'the rule will return `off` if attribute `version` is not in list (`1.22.9`, `2.1.0`)'); | ||
| assert.equal(client.getTreatment('semver_inlist', { 'version': null }), 'off', 'the rule will return `off` if attribute `version` is not the expected type'); | ||
|
|
||
| // GREATER_THAN_OR_EQUAL_TO_SEMVER matcher | ||
| assert.equal(client.getTreatments(['semver_greater_or_equalto'], { 'version': '1.23.9' }).semver_greater_or_equalto, 'on', 'the rule will return `on` if attribute `version` is greater than or equal to `1.22.9`'); | ||
| assert.equal(client.getTreatments(['semver_greater_or_equalto'], { 'version': '1.22.9' }).semver_greater_or_equalto, 'on', 'the rule will return `on` if attribute `version` is greater than or equal to `1.22.9`'); | ||
| assert.equal(client.getTreatments(['semver_greater_or_equalto'], { 'version': '1.22.9+build' }).semver_greater_or_equalto, 'on', 'build metadata is ignored'); | ||
| assert.equal(client.getTreatments(['semver_greater_or_equalto'], { 'version': '1.22.9-rc.0' }).semver_greater_or_equalto, 'off', 'the rule will return `off` if attribute `version` is not greater than or equal to `1.22.9`'); | ||
| assert.equal(client.getTreatments(['semver_greater_or_equalto'], { 'version': '1.21.9' }).semver_greater_or_equalto, 'off', 'the rule will return `off` if attribute `version` is not greater than or equal to `1.22.9`'); | ||
| assert.equal(client.getTreatments(['semver_greater_or_equalto'], { 'version': 'invalid' }).semver_greater_or_equalto, 'off', 'the rule will return `off` if attribute `version` is an invalid semver value'); | ||
|
|
||
| // LESS_THAN_OR_EQUAL_TO_SEMVER matcher | ||
| assert.deepEqual(client.getTreatmentWithConfig('semver_less_or_equalto', { 'version': '1.22.11' }), { treatment: 'off', config: null }, 'the rule will return `off` if attribute `version` is not less than or equal to `1.22.9`'); | ||
| assert.deepEqual(client.getTreatmentWithConfig('semver_less_or_equalto', { 'version': '1.22.9' }), { treatment: 'on', config: null }, 'the rule will return `on` if attribute `version` is less than or equal to `1.22.9`'); | ||
| assert.deepEqual(client.getTreatmentWithConfig('semver_less_or_equalto', { 'version': '1.22.9+build' }), { treatment: 'on', config: null }, 'build metadata is ignored'); | ||
| assert.deepEqual(client.getTreatmentWithConfig('semver_less_or_equalto', { 'version': '1.22.9-rc.0' }), { treatment: 'on', config: null }, 'the rule will return `on` if attribute `version` is less than or equal to `1.22.9`'); | ||
| assert.deepEqual(client.getTreatmentWithConfig('semver_less_or_equalto', { 'version': '1.21.9' }), { treatment: 'on', config: null }, 'the rule will return `on` if attribute `version` is less than or equal to `1.22.9`'); | ||
| assert.deepEqual(client.getTreatmentWithConfig('semver_less_or_equalto', { 'version': {} }), { treatment: 'off', config: null }, 'the rule will return `off` if attribute `version` is not the expected type'); | ||
|
|
||
| const client2 = splitio.client('2nd'); | ||
| await client2.ready(); | ||
|
|
||
| // BETWEEN_SEMVER matcher | ||
| assert.deepEqual(client2.getTreatmentsWithConfig(['semver_between'], { 'version': '2.1.1' }).semver_between, { treatment: 'off', config: null }, 'the rule will return `off` if attribute `version` is not between `1.22.9` and `2.1.0`'); | ||
| assert.deepEqual(client2.getTreatmentsWithConfig(['semver_between'], { 'version': '2.1.0+build' }).semver_between, { treatment: 'on', config: null }, 'build metadata is ignored'); | ||
| assert.deepEqual(client2.getTreatmentsWithConfig(['semver_between'], { 'version': '1.25.0' }).semver_between, { treatment: 'on', config: null }, 'the rule will return `on` if attribute `version` is between `1.22.9` and `2.1.0`'); | ||
| assert.deepEqual(client2.getTreatmentsWithConfig(['semver_between'], { 'version': '1.22.9' }).semver_between, { treatment: 'on', config: null }, 'the rule will return `on` if attribute `version` is between `1.22.9` and `2.1.0`'); | ||
| assert.deepEqual(client2.getTreatmentsWithConfig(['semver_between'], { 'version': '1.22.9-rc.0' }).semver_between, { treatment: 'off', config: null }, 'the rule will return `off` if attribute `version` is not between `1.22.9` and `2.1.0`'); | ||
| assert.deepEqual(client2.getTreatmentsWithConfig(['semver_between'], { 'version': [] }).semver_between, { treatment: 'off', config: null }, 'the rule will return `off` if attribute `version` is not the expected type'); | ||
|
|
||
| // Evaluation of a flag with unsupported matcher | ||
| assert.equal(client2.getTreatment('flag_with_unsupported_matcher'), 'control', 'evaluation of a flag with an unsupported matcher should return control'); | ||
|
|
||
| let POSTED_IMPRESSIONS_COUNT; | ||
|
|
||
| fetchMock.postOnce(config.urls.events + '/testImpressions/bulk', (_, opts) => { | ||
|
|
||
| const payload = JSON.parse(opts.body); | ||
|
|
||
| function validateImpressionData(featureFlagName, expectedImpressionCount, expectedOnCount, expectedLabel, expectedTreatment = 'on') { | ||
| const impressions = payload.find(e => e.f === featureFlagName).i; | ||
|
|
||
| assert.equal(impressions.length, expectedImpressionCount, `We should have ${expectedImpressionCount} impressions for the feature flag ${featureFlagName}`); | ||
| assert.equal(impressions.filter((imp) => imp.r === expectedLabel && imp.t === expectedTreatment).length, expectedOnCount, `${expectedOnCount} impression with 'on' treatment and label ${expectedLabel}`); | ||
| } | ||
|
|
||
| validateImpressionData('semver_equalto', 5, 1, 'equal to semver'); | ||
| validateImpressionData('semver_inlist', 5, 2, 'in list semver'); | ||
| validateImpressionData('semver_greater_or_equalto', 6, 3, 'greater than or equal to semver'); | ||
| validateImpressionData('semver_less_or_equalto', 6, 4, 'less than or equal to semver'); | ||
| validateImpressionData('semver_between', 6, 3, 'between semver'); | ||
| validateImpressionData('flag_with_unsupported_matcher', 1, 1, 'targeting rule type unsupported by sdk', 'control'); | ||
|
|
||
| POSTED_IMPRESSIONS_COUNT = payload.reduce((acc, curr) => acc + curr.i.length, 0); | ||
|
|
||
| return 200; | ||
| }); | ||
|
|
||
| await Promise.all([client.destroy(), client2.destroy()]); | ||
|
|
||
| setTimeout(() => { | ||
| assert.equal(listener.logImpression.callCount, POSTED_IMPRESSIONS_COUNT, 'Impression listener should be called once per each impression generated.'); | ||
|
|
||
| assert.end(); | ||
| }, 0); | ||
| } |
Oops, something went wrong.